P@ Sunglasses

All | AOP | blogs.sun.com | books | Cool | Fun | General | Java | OpenSource | Personal | Portals | Rome | Syndication | wallstreet | Weblog
« Rome Atom/RSS utilit... | Main | A few interesting... »

20040617 e enjte qershor 17, 2004

Roller bug: bookmark images need to be included directly when the image name begins with http:// Nice catch by Torrey McMahon in the Sun bloggers mailing list today.
We need to fix that in Roller.

Torrey McMahon wrote:
I noticed that the bookmarks allow you to set images. I went through and
added a few but the links get set related to the blog page. For example:
If I configd the icon to be

    http://i.cnn.net/cnn/.element/img/1.1/logo/logo.gif

it gets turned into

    /roller/resources/torrey/http://i.cnn.net/cnn/.element/img/1.1/logo/logo.gif

Is there a way to fix that?

This is a Roller bug.
If you look at your template:

Website/Pages/Template/Weblog template
There's something like this
        <div class="sidebarBox">
            <div class="links">
                #showBookmarks("Blogroll" true false)
            </div>
        </div>
       
        <div class="sidebarBox">
            <div class="links">
                #showBookmarks("News" true false)
            </div>
        </div>

Then in Roller code
web/WEB-INF/classes/bookmark.vm
#macro( showOneBookmark $bookmark )
    #if( $utilities.isNotEmpty( $bookmark.Image ) )
        <a href="$bookmark.Url"><img alt="$bookmark.Name"
        src="$baseURL#showResourcePath()/$bookmark.Image" /></a><br />

$bookmark.Image should be checked for the uri scheme first: if there is one and it is http, then $bookmark.Image should be used and not prefixed with $baseURL#showResourcePath()/
I've added that to my weblog in the blogs.sun.com category, that I use to track the requirements for Sun Roller.
Later on we'll create an aggregated site with this category to get all the requirements.

( Qer 17 2004, 04:20:29 PD PDT ) Permalink Comments [2] Chat about it Technorati cosmos Tagsurf It

Comments:

It is just as you say. Did you point out that Torrey could upload the image and reference it that way? Not as efficient, but then her blog isn't reliant on an outside server for displaying the icon.

Posted by Lance on qershor 17, 2004 at 10:08 PD PDT #

Thanks Lance, I did not. But for that kind of use, in a blogroll, where you would get the images from people's blog, I guess it's not the right usage to have to download them, then upload them to your own. People may change their images and you don't want to have to maintain that.

Posted by Patrick Chanezon on qershor 17, 2004 at 03:56 MD PDT #

Post a Comment:

Comments are closed for this entry.

Valid HTML! Valid CSS!

This is a personal weblog, I do not speak for my employer.