Let's Swing!
A globally warmed, Swing focused blog in the Participation Age.
I've definitely moved this blog to my personal site!
« SwingWorker: timing-... | Main | SwingWorker: the... »

SwingWorker: clean up the mess before leaving

jueves agosto 18, 2005 | SwingWorker | Permalink |
Of course you add a PropertyChangeListener to a SwingWorker's list of listeners to be informed of advances in the progress of computations and to notice changes in SwingWorker's status.

But, when do you remove those listeners? Of course if you don't remove listeners then you keep references from the SwingWorker to the listeners and that may lead to memory leaks.

Of course the safest place to remove listeners is when the SwingWorker is done. Something like this: 

public void propertyChange(java.beans.PropertyChangeEvent propertyChangeEvent)
{
  SwingWorker source = (SwingWorker) propertyChangeEvent.getSource();
  if ( "state".equals( propertyChangeEvent.getPropertyName() )
       && (source.isDone() || source.isCancelled() ) )
  {
    source.removePropertyChangeListener( this );
  }
}
So the listener removes itself when the SwingWorker is done. Easy and clean. So here we go with another suggestion for SwingWorkers:

SwingWorker suggestion IV: Clean up listeners when done Each PropertyChangeListener should remove itself from the list of listeners whenever the SwingWorker is done.
Enough for today. Keep swinging,
Antonio

Comentarios:

Enviar un comentario:

Los comentarios han sido deshabilitados.

Categories

Todo | Complexity | Event bus | General | Global Warming | J2EE | Java Swing | Personal | Sun | SwingWorker | Who is this guy, anyway?

Search


Recent entries


Sites I find interesing

Aggregators
Swing focused
Software architecture related @ blogs.sun.com

Calendar

« diciembre 2009
lunmarmiéjueviesábdom
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
   
       
Hoy

Navigation


blogs.sun.com
Weblog
Entrar

Visits

Locations of visitors to this page
© Copyright Antonio Vieiro, 2005.
The opinions expressed here by me are my own, so I am the only one responsible for them. Sun Microsystems does not necessarily agree with any of them. Opinions and comments freely expressed by third parties may be copyrighted by them, of course. Nor Sun Microsystems nor I do necessarily agree with any of them either. Spam comments are prohibited and may be prosecuted by law in different countries. But, now, who gets rid of spam nowadays?