My first xVM putback
I did my first xVM gatekeeping putback today - pretty minor changes to some build scripts, but a nice way to ease myself into the joys of dealing with hg, MQ and our gate setup. Thanks to johnlev for helping me through the putback procedure!
For those that care, the bug was http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6710070 - and if anyone's interested, you can see the fix as a comment to this post.
My next task, is to tackle the xvm-unstable gate. At the moment, for contributers to the Xen Community on OpenSolaris.org, building the unstable bits is a bit unweildy - at least more so than building the current stable gate that's used for Nevada. We've got 3 repositories up there at the moment, but my aim is to make the rest of our repositories available, and get the build and gate management scripts to work regardless of whether you've got a sun.com email address.
changeset: 23:0ab178771afc
tag: tip
user: Tim Foster <tim [dot] foster [at] sun [dot] com>
date: Wed Jun 11 03:17:53 2008 -0700
files: bin/build-webrev inc/xvm.ksh
description:
6710070 build-webrev doesn't clean up MQ gates
diff -r 985c0a4b4c66 -r 0ab178771afc bin/build-webrev
--- a/bin/build-webrev Tue Jun 10 09:18:52 2008 -0700
+++ b/bin/build-webrev Wed Jun 11 03:17:53 2008 -0700
@@ -158,4 +158,5 @@ for gate in libvirt.hg urlgrabber.hg sun
mkdir -p $outdir/$patch 2>/dev/null || :
webrev $openflag -r $patch -o $outdir/$patch
done
+ pop_all $gate
done
diff -r 985c0a4b4c66 -r 0ab178771afc inc/xvm.ksh
--- a/inc/xvm.ksh Tue Jun 10 09:18:52 2008 -0700
+++ b/inc/xvm.ksh Wed Jun 11 03:17:53 2008 -0700
@@ -302,17 +302,20 @@ push_gate() {
push_gate() {
gate=$1
parent=$2
- parentgate=`parentgate $gate $parent`
-
- [ `outgoing $gate $parentgate` -eq 0 ] || \
- hg -R $XVM_WS/$gate push -v $parent/$gate
if [ `is_mq_gate $gate` -eq 1 ]; then
+ pop_all $gate
patchgate="$gate/.hg/patches"
parentgate=`parentgate $patchgate $parent`
[ `outgoing $patchgate $parentgate` -eq 0 ] || \
hg -R $XVM_WS/$patchgate push -v $parentgate
fi
+
+ parentgate=`parentgate $gate $parent`
+
+ [ `outgoing $gate $parentgate` -eq 0 ] || \
+ hg -R $XVM_WS/$gate push -v $parent/$gate
+
}
push_gates() {
Posted by Tim Foster on June 11, 2008 at 04:13 PM IST #
Very cool man, congrats !
Posted by Rafael on June 12, 2008 at 12:07 AM IST #
Congrats!!! :)
Posted by Glynn Foster on June 14, 2008 at 02:13 AM IST #
Quick update: I <a href="http://bugs.opensolaris.org/view_bug.do?bug_id=6714450">6714450</a> integrated yesterday - nearly there!
Posted by Tim Foster on June 28, 2008 at 05:43 PM IST #